Added windows support#67
Merged
MelvinFrederiks merged 7 commits intoApr 16, 2026
Merged
Conversation
Collaborator
|
I have played around with this, I am bit worried by the code as it is indeed so slow under windows. Maybe you could find a solution for this? |
Contributor
Author
@zyronix now it performs similar in speed on WIndows, Can you review this pull request again? I did had to pin the chardet version to an old version, because some tests will fail on a recent chardet version (regardless of the code changes in this branch), because in some of the test cases, files will be wrongly recognized in Herbrew. We probably have to think how to handle chardet guesses with a low confidence rating. |
MelvinFrederiks
merged commit 5460f9c
into
NetherlandsForensicInstitute:master
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #61 for windows.
Added windows support by:
I have tested this code by running the tests on windows 11 from powershell and also on WSL with debian to check if this also still works on Linux. What I did notice is that Windows performs way worse than on Linux. It took windows 4:18 minutes to pass all tests vs 4,40 seconds on Linux. I assume this has something to do with how windows does multithreading.